Liviu Nicoara wrote:
I am sorry, I spaced on it. I am going to tend to it as soon as I can.
Liviu, please don't forget to commit this. FWIW, the patch is very
simple (see the attachment).
Martin
Liviu
Martin Sebor wrote:
Martin Sebor wrote:
Liviu Nicoara wrote:
I have attached my attempt at converting new.cpp "self" test to the new
driver.
[...]
PS Also, the formatting strings passed to the rw_error() calls in
new.cpp have redundant trailing newlines -- they should be removed.
Could you please make the change and commit it?
Liviu, any progress on this?
Martin
Index: /build/sebor/stdcxx/tests/src/new.cpp
===================================================================
--- /build/sebor/stdcxx/tests/src/new.cpp (revision 376097)
+++ /build/sebor/stdcxx/tests/src/new.cpp (working copy)
@@ -134,7 +134,7 @@
if (hdr->self_ != hdr) {
rw_error (0, 0, __LINE__,
"%s:%d: header guard corruption at %p: "
- "expected %p, got %p\n",
+ "expected %p, got %p",
hdr->ptr_, (const void*)hdr, hdr->self_);
abort ();
}
@@ -143,7 +143,7 @@
if (hdr->ptr_ != hdr + 1) {
rw_error (0, 0, __LINE__,
"%s:%d: block address mismatch: "
- "expected %p, got %p\n",
+ "expected %p, got %p",
__FILE__, __LINE__,
(const void*)(hdr + 1), hdr->ptr_);
@@ -163,7 +163,7 @@
rw_error (0, 0, __LINE__,
"%s:%d: trailing guard corruption at %p "
- "+ %zu of a %zu byte block: '0x%02x' != '0x%x'\n",
+ "+ %zu of a %zu byte block: '0x%02x' != '0x%x'",
__FILE__, __LINE__, hdr->ptr_,
hdr->size_ + off + 1, hdr->size_,
UChar (grd [off]), UChar (Guard [off]));
@@ -189,7 +189,7 @@
rw_error (0, 0, __LINE__,
"%s:%d: counts mismatch: found %zu "
"bytes in %zu blocks, expected "
- "%zu in %zu\n", __FILE__, __LINE__,
+ "%zu in %zu", __FILE__, __LINE__,
nbytes, nblocks, sum_bytes, sum_blocks);
abort ();
@@ -201,7 +201,7 @@
#if !defined (__DECCXX_VER) || __DECCXX_VER >= 60600000
rw_error (0, 0, __LINE__,
- "%s:%d: %s (%p): invalid pointer\n",
+ "%s:%d: %s (%p): invalid pointer",
__FILE__, __LINE__, caller, ptr);
_rw_print_heap ();
@@ -215,7 +215,7 @@
if (static_dtors) {
rw_error (0, 0, __LINE__,
- "%s:%d: %s (%p): invalid pointer\n",
+ "%s:%d: %s (%p): invalid pointer",
__FILE__, __LINE__, caller, ptr);
print_heap ();
