First things I've noticed: 1. [cosmetic] when the disable button is pressed for a plugin, it re-sizes the window, which is very ugly.
2. [more serious] for the Satellites plugin, if the configuration dialog is opened when the disable button is pressed, the window becomes unresponsive, and cannot be closed. I take from this that it is necessary to destroy the config dialog from the destructor of the plugin, or the ::deinit member. I would like to draw up a list of all these sorts of things which must be done when a plugin is disabled. So here's the start of a list of things to remember to do when a plugin is disabled: i) close dialogs ii) stop / delete timers which might be running (in the case of the Satellites plugin, the update timers) iii) stop, wait for and close any open network connections (in the case of the Satellites plugin, the update network connections) iv) disconnect anything which is somehow connect()ed to the object (does QT do this automatically?) v) anything else? M ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Stellarium-pubdevel mailing list Stellarium-pubdevel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
