Nigel,

Thanks for your response.

Nigel Smith wrote:
> Tim,
> First off, I'd just like to thank you for publishing this code
> review, and allowing the storage community a chance to comment
> on your proposed changes, before the 'putback'.
>
> I've only had time for a quick glance over the code, but
> basically I see you are splitting the 'S6 Freeing' state into two
> separate states, which you are naming 'S6-IN' and 'S6-AIO'.
>   
Yes, the S6 state is broken up into 2 states, one case is to handle 
theT10_Cmd_T6 (command cancel)
while in the lu_runner (S6-IN  original implementation), the S6-AIO (new 
state) is to handle while the command
is in the AIO state, since we have to wait for aio_done and then free 
resouce.

There are other modifications to handle the T10_Cmd_T6 in the T10 State 
Machine.

-Tim
> I hope to have the time for a closer look over the next few days,
> and then to be able to give some feedback.
>
> Oh and it's also your first post to the OpenSolaris storage forum!  
> Well done :-)
> Best Regards
> Nigel Smith
>  
>  
> This message posted from opensolaris.org
> _______________________________________________
> storage-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/storage-discuss
>   
_______________________________________________
storage-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/storage-discuss

Reply via email to