On Sun, Mar 8, 2009 at 3:31 AM, Dale Ghent <[email protected]> wrote: > > On Mar 8, 2009, at 4:27 AM, Dale Ghent wrote: > >> On Mar 7, 2009, at 4:54 PM, Jason King wrote: >> >>> Since the ball has already started to roll on this, I'd like to >>> 'officially' ask for feedback on my current proposed design for link >>> layer discovery support (specifically LLDP -- possibly in the future >>> other protocols such as CDP or EDP can be added in). The current >>> documentation can be seen at >>> http://www.opensolaris.org/os/project/lld/design >> >> Huzzah! Awesome work, Jason. >> >> I was reading over the Operation document and the paragraph describing >> what will populate the System Description TLV and a thought occurred to me. >> >> One of the components you're using to populate this TLV is SI_PLATFORM >> from sysinfo. On SPARC boxen, this will produce a string akin to >> "SUNW,Ultra-4" or "SUNW,Sun_Fire_T200" and so on. However, on x86, this will >> always be "i386". I think that can be improved. > > Err, blame the hour/DST change. On x86, this is "i86pc", not "i386" :) Not > that it changes the point I'm trying to make :) > > >> You may want to consider hooking into libsmbios on x86 to gain use of the >> SMB_TYPE_SYSTEM array which contains a product string not too dissimilar >> than what you'd get with SI_PLATFORM on Sun SPARC boxes. >> >> For example, this could produce "Sun Fire X4140" or "PowerEdge 1950" and >> so on, and be a bit more informative than the generic and rather vague >> "i386" that you'd normally get on x86 using SI_PLATFORM. >> >> Peruse the output of smbios(1M) if you think anything from a x86 box's >> SMBIOS might be useful. libsmbios is where prtdiag(1M) on x86 boxes gets its >> output. > > /dale >
Seems reasonable. The prototype won't have that since I don't want to use any private interfaces for it (makes building it more complicated). Since it looks like it ON will be the most appropriate place for it, I don't believe it would be an issue to use libsmbios in the final code. It might be worth allowing that to be set to an administratively set value (with what's there now as a default). _______________________________________________ storage-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/storage-discuss
