On Tue, Apr 17, 2012 at 04:36:12PM -0400, Mike Frysinger wrote:
> Needed to debug some losetup failures, and it's easier when you can see
> what the kernel is getting vs what you think you're sending, so add some
> decoders for those ioctls.

Thanks.

[...]
> +             if (!abbrev(tcp)) {
> +                     tprintf("device=%" PRIi64 ", inode=%" PRIi64 ", "
> +                             "rdevice=%" PRIi64 ", offset=%#" PRIx64 ", "
> +                             "sizelimit=%" PRIi64 ", number=%" PRIi32,
> +                             (uint64_t) info64.lo_device,
> +                             (uint64_t) info64.lo_inode,
> +                             (uint64_t) info64.lo_rdevice,
> +                             (uint64_t) info64.lo_offset,
> +                             (uint64_t) info64.lo_sizelimit,
> +                             (uint32_t) info64.lo_number);
> +             } else {

We can have more consistency here, e.g. natural printing format specifiers
for uint64_t are PRIu64 and PRIx64, while PRIi64 is more appropriate for
the signed type.


-- 
ldv

Attachment: pgpB8TZmKR2lF.pgp
Description: PGP signature

------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
Strace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to