Hi,

On Sat, Mar 21, 2015 at 05:06:32PM +0000, Denys Vlasenko wrote:
[...]
> commit 8497b6222ed8ef606996d0ceb2bae260d82f95e2
> Author: Denys Vlasenko <dvlas...@redhat.com>
> Date:   Sat Mar 21 17:51:52 2015 +0100
> 
>     Show the syscall name in "resuming interrupted call" message

It's nice when it works, but you've broken ARM and probably other
architectures:

$ ./strace true
pid 1234 stray syscall exit
Segmentation fault

[...]
> --- a/strace.c
> +++ b/strace.c
> @@ -2153,6 +2153,8 @@ trace(void)
>       if (tcp->flags & TCB_STARTUP) {
>               if (!startup_tcb(tcp))
>                       return false;
> +             if (get_scno(tcp) == 1)
> +                     tcp->s_prev_ent = tcp->s_ent;

Here you call get_scno() which was never called outside
trace_syscall_entering() before.  Every architecture implements get_scno()
in its own way, and some of these implementations are not ready for this
change.

Denys, please post non-trivial patches for review before pushing them
to HEAD.


-- 
ldv

Attachment: pgpILRWAutJI7.pgp
Description: PGP signature

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to