Hi, On Fri, Mar 11, 2016 at 11:22:23PM +0530, Jay Joshi wrote: > Hello, > > This is my first attempt to add test for syscall (here, chdir). Any > suggestion, comment, criticism is welcomed.
chdir is already well covered, see $ git grep chdir tests You must have missed my recommendation to check current coverage report at https://codecov.io/github/strace/strace before adding new tests. I think you'd rather take something that's not tested at all. > +#if defined __NR_chdir Why do you think that libc wrapper for chdir syscall is not suitable? > + if (errno == ENOSYS) { > + printf("chdir(\"%s\") = -1 ENOSYS (%m)\n", sample_dir); chdir failing with ENOSYS? Really? -- ldv
pgp90aWTwSCzC.pgp
Description: PGP signature
------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
_______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
