Revision: 1344
          http://stripes.svn.sourceforge.net/stripes/?rev=1344&view=rev
Author:   bengunter
Date:     2010-11-13 16:15:05 +0000 (Sat, 13 Nov 2010)

Log Message:
-----------
Fixed STS-782: Stripes fails to remove values from a ThreadLocal variable in 
StripesFilter, Tomcat says. Call ThreadLocal.remove() on initialInvocation 
instead of .set(true) to prevent this leak.

Modified Paths:
--------------
    
branches/1.5.x/stripes/src/net/sourceforge/stripes/controller/StripesFilter.java

Modified: 
branches/1.5.x/stripes/src/net/sourceforge/stripes/controller/StripesFilter.java
===================================================================
--- 
branches/1.5.x/stripes/src/net/sourceforge/stripes/controller/StripesFilter.java
    2010-11-12 20:57:56 UTC (rev 1343)
+++ 
branches/1.5.x/stripes/src/net/sourceforge/stripes/controller/StripesFilter.java
    2010-11-13 16:15:05 UTC (rev 1344)
@@ -252,11 +252,11 @@
         finally {
             // reset the flag that indicates if this is the initial invocation
             if (initial) {
-                initialInvocation.set(true);
                 flashOutbound(httpRequest);
 
-                // Once the request is processed, take the Configuration back 
out of thread local
+                // Once the request is processed, clean up thread locals
                 StripesFilter.configurationStash.remove();
+                StripesFilter.initialInvocation.remove();
             }
             else {
                 // restore URI parameters to their previous state


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Stripes-development mailing list
Stripes-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to