+1 on unit tests :) Don
On Mon, 1 Dec 2003 [EMAIL PROTECTED] wrote: > > > > Is it okay if I add you as an author to the JavaDocs? > > Yep :) > > > > Afterwards we are ready for the 0.2.0 release. > > Cool. I guess we need to update the docs with all the new stuff? > > > > So ... what do we want to implement next? :-) > > I'd really like to include the ActionInterceptor.destroy() stuff I sendt > you. > > It's really usefull for interceptors that needs to clean up after > themselves. > > Imagine this scenario for instance: > > My interceptor starts a java.util.TimerTask. The TimerTask lives in the > system classloader and is not affected by a webapp reaload. If the > interceptor is not notified when the webapp is reloaded it will not have a > chance to cancel the TimerTask, and the interceptor in the reloaded webapp > will add a new one. After five reloads you would have five TimerTasks > running on top of each other. > > It's not much code and I have it all ready. > > I'd also like to argue for this change being included in SAIF 0.2. With this > change I think the primary interface (ActionInterceptor) can solidify which > will move SAIF out of the alpha stage. > > I can not think of any other basic functionality SAIF needs right now. I > think it is very important to keep the SAIF-core in line with the KISS > pinciple (http://www.faqs.org/docs/jargon/K/KISS-Principle.html). > > Maybe its time to focus on optional add-ons pluss stability and performance > improvements? > > We have been discussing adding an adapter layer for IoC containers. I can > start having a look at that if you want. > > I have nothing against adding optional functionality to SAIF, but I believe > it is wery important to keep the SAIF core "clean". That is: People should > be able to use SAIF proper without adding additional libraries to their > apps. This can be achieved by having a proper plug-in architecture and/or > referencing optional libs through reflection in the core classes. > > I can also do some profiling of the SAIF code if you want. > > I was also wondering what your attitude to unit testing is? I could have a > look at making Cactus tests for SAIF. However, I believe this is an "all or > nothing" descicion. Either we dont use unit testing or we back *all* new > functionality with tests. > > CHR > > > > -----Original Message----- > > From: Lars Hoss [mailto:[EMAIL PROTECTED] > > Sent: 28. november 2003 18:47 > > To: [EMAIL PROTECTED] > > Subject: Fwd: [Struts-apps] [SAIF] Added support for interceptor > > properties per action > > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Sorry, but I replied to the author. Here's the response. > > > > Anfang der weitergeleiteten E-Mail: > > > > > Von: Lars Hoss <[EMAIL PROTECTED]> > > > Datum: 28. November 2003 18:45:15 MEZ > > > An: [EMAIL PROTECTED] > > > Betreff: Re: [Struts-apps] [SAIF] Added support for interceptor > > > properties per action > > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > Hi! > > > > > >> Is it not better to keep the configuration on one level? > > > > > > Well, perhaps yes. But someone asked me to implement this feature. > > > Anyway, cool that everything works :-) > > > > > > Is it okay if I add you as an author to the JavaDocs? > > > Afterwards we are ready for the 0.2.0 release. > > > > > > So ... what do we want to implement next? :-) > > > > > > Yours, > > > Lars > > > > > > -----BEGIN PGP SIGNATURE----- > > > Version: PGP 8.0.3 > > > > > > iQA/AwUBP8eJtrcyzbDWnRDCEQIL1QCg/yXcrU37w0oEFThXsdY2ArCSL0YAoOKh > > > NNwkdud4b+5QdYbW8FBWhT2L > > > =sq+1 > > > -----END PGP SIGNATURE----- > > > > > > > -----BEGIN PGP SIGNATURE----- > > Version: PGP 8.0.3 > > > > iQA/AwUBP8eKDLcyzbDWnRDCEQIpnQCg7u5AKB9Oe+CKAhYGLupPCL04ilgAoIf2 > > IztJbB6f0ZRa/YShWxZ5nl2M > > =xAz9 > > -----END PGP SIGNATURE----- > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: SF.net Giveback Program. > > Does SourceForge.net help you be more productive? Does it > > help you create better code? SHARE THE LOVE, and help us help > > YOU! Click Here: http://sourceforge.net/donate/ > > _______________________________________________ > > Struts-apps mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/struts-apps > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Struts-apps mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/struts-apps > ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ Struts-apps mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/struts-apps
