----- Original Message ----- From: "Ted Husted" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, February 05, 2002 8:24 PM Subject: Re: Tiles and Struts 1.0.1 release : ActionForm problem
> Yes, that's it AFAIK. > > Did someone apply the patch already? I went to do it but it seems to be > done. I don't see the CVS event. If it isn't there, maybe I need a > fresh checkout. The change wasn't there in the branch, so perhaps you do need a fresh tree. I just checked in the change to ActionForm, so you should see the commit message shortly. > Unless there's something else, I don't think we need a formal release > candidate, but we could confirm that the current 1_0 BRANCH now works > with Cedric, [EMAIL PROTECTED], and [EMAIL PROTECTED] who > have reported the problem. Maybe we could post it in the release > candidate directory long enough for these three to confirm, and then > just move it over. That sounds fine. What should we do about release notes? -- Martin Cooper > > -T. > > > > Martin Cooper wrote: > > > > I can do it - I still have the 1.0.1 release tree set up on my machine. > > > > So, to confirm what we're doing, the only changes are: > > > > 1) Make ActionForm.getMultipartRequestHandler() public instead of protected. > > 2) Update the version number to 1.0.2. > > > > As soon as I hear back on this, I'll check in the changes and upload a > > build. > > > > Question: Do we want a Release Candidate build? > > > > Here's my proposal for how we handle this, given the very limited scope of > > the release: > > > > a) I check in the changes noted above. > > b) I upload a build into the 1.0.2 release location. > > c) Someone (Cedric? Ted?) verifies that Tiles works with that build. > > d) I announce the release. > > > > Another question: What do we do about release notes for this one? > > > > -- > > Martin Cooper > > > > ----- Original Message ----- > > From: "Ted Husted" <[EMAIL PROTECTED]> > > To: "Struts Developers List" <[EMAIL PROTECTED]> > > Sent: Tuesday, February 05, 2002 10:00 AM > > Subject: Re: Tiles and Struts 1.0.1 release : ActionForm problem > > > > > It's a bug. Mea culpa. > > > > > > I think we'll need to change that and pop-out a 1.0.2 release. > > > > > > Sorry about that. > > > > > > Martin, did you want to do this one too, or should I? > > > > > > -T. > > > > > > > > > > > > Cedric Dumoulin wrote: > > > > > > > > Some user have reported that Tiles don't compile with Struts 1.0.1. > > > > > > > > The problem come from the fact that method > > > > getMultipartRequestHandler() in ActionForm is protected in 1.0.1. > > > > Checking the log, it appear that it is for bug #4997. The same patch > > > > has been applied in head branch, but method still public. So, we are > > > > facing an inconsistency : do we need it protected or public ? > > > > > > > > If protected, Tiles servlet doesn't work anymore with 1.0.1, because > > > > it has a copy of ActionServlet.processValidate() method, which do a call > > > > to the protected method getMultipartRequestHandler() ;-(. > > > > For now there is two solutions : > > > > > > > > * Change back protected to public if we don't need > > > > getMultipartRequestHandler() to be protected. This still > > > > problematic because 1.0.1 is an official release > > > > * Move Tiles servlet into the same package as ActionForm and > > > > ActionServlet. But in this case full tiles servlet name change, and > > > > backward compatibility is broken for Tiles ;-( > > > > > > > > Does someone have another idea ? > > > > > > > > Cedric > > > > > > > > -- > > > > To unsubscribe, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > > For additional commands, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > > > > -- Ted Husted, Husted dot Com, Fairport NY USA. > > > -- Java Web Development with Struts. > > > -- Tel +1 585 737-3463. > > > -- Web http://www.husted.com/struts/ > > > > > > -- > > > To unsubscribe, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > For additional commands, e-mail: > > <mailto:[EMAIL PROTECTED]> > > > > > > > -- > > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- Ted Husted, Husted dot Com, Fairport NY USA. > -- Java Web Development with Struts. > -- Tel +1 585 737-3463. > -- Web http://www.husted.com/struts/ > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
