Since we are all bashing David (LOL...just kidding), may I make one more suggestion.
Can we all agree to separate code changes with format changes? I usually check every commit to see if it impacts something I might be working on (bug fix or personal dev) and as I was browsing my mail this morning, I found that reading through a couple of "recent commits " <wink/> was giving me a migraine. Finding the actual code changes was impossible. In fact, we probably should not be using our IDE's 'reformat' features unless the current page formatting is complete crap. If we each reformat every time we open and change a file. We will see battles emerging between JBuilder, NetBeans, Eclipse, and others. If that sounds feasible, I would also recommend to those of us just using text editors to turn off the 'trim trailing spaces' when saving. This causes just as much of a headache. Your thoughts? James Mitchell Software Engineer/Struts Evangelist http://www.open-tools.org "If you were plowing a field, which would you rather use? Two strong oxen or 1024 chickens?" - Seymour Cray (1925-1996), father of supercomputing > -----Original Message----- > From: David Graham [mailto:dgraham1980@;hotmail.com] > Sent: Tuesday, November 12, 2002 12:10 PM > To: [EMAIL PROTECTED] > Subject: RE: Replacing Action.* with Globals.* > > > You are right. I didn't wait long enough because I was making > other changes > and didn't want to get confused about which ones to commit. > > David > > > > > > > >From: "Martin Cooper" <[EMAIL PROTECTED]> > >Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> > >To: "'Struts Developers List'" <[EMAIL PROTECTED]> > >Subject: RE: Replacing Action.* with Globals.* > >Date: Tue, 12 Nov 2002 08:49:49 -0800 > > > > > > > > > -----Original Message----- > > > From: David Graham [mailto:dgraham1980@;hotmail.com] > > > Sent: Tuesday, November 12, 2002 8:30 AM > > > To: [EMAIL PROTECTED] > > > Subject: Re: Replacing Action.* with Globals.* > > > > > > > > > I committed the updates last night because I didn't hear > > > anyone complain. > > > >I don't have a problem with the changes. > > > >I would like to point out, however, that you only waited 3 hours for > >feedback. Not all of us are in the same country, let alone the same time > >zone. Cedric, for example, had no hope of responding in time, unless he > >happened to be reading Struts mail at around 3am his time (my estimate). > >Even those of us in an appropriate time zone are not all constantly > >checking > >mail to struts-dev. > > > >Given your statement that you "would hate to do this and have to back out > >the changes" (which I understand :), I would suggest that you > might want to > >allow more time for people to respond before going ahead with > changes like > >this. Otherwise, you do leave yourself open to having to back out the > >changes. > > > >-- > >Martin Cooper > > > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > >From: Eddie Bush <[EMAIL PROTECTED]> > > > >Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> > > > >To: Struts Developers List <[EMAIL PROTECTED]> > > > >Subject: Re: Replacing Action.* with Globals.* > > > >Date: Tue, 12 Nov 2002 09:41:04 -0600 > > > > > > > >Well, we're headed toward using Globals instead of Action > > > for this purpose, > > > >so I'd think it would be highly desirable for the internal > > > code to use > > > >those constants located in Globals. > > > > > > > >... The Action constants can't go away yet (at least I > > > believe that's the > > > >decision that was arrived at), but I can't see where > > > changing internal code > > > >to use Global references over Action references would be a bad thing. > > > > > > > >David Graham wrote: > > > > > > > >>Is it ok to replace the Action constant references with > > > Globals constant > > > >>references in the Struts code? I would hate to do this and > > > have to back > > > >>out the changes. > > > >> > > > >>Thanks, > > > >>Dave > > > > > > > > > > > >-- > > > >Eddie Bush > > > > > > > > > > > > > > > > > > > > > > > >-- > > > >To unsubscribe, e-mail: > > > ><mailto:struts-dev-unsubscribe@;jakarta.apache.org> > > > >For additional commands, e-mail: > > > ><mailto:struts-dev-help@;jakarta.apache.org> > > > > > > > > > _________________________________________________________________ > > > MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. > > > http://join.msn.com/?page=features/virus > > > > > > > > > -- > > > To unsubscribe, e-mail: > > > <mailto:struts-dev-unsubscribe@;jakarta.apache.org> > > > For additional commands, e-mail: > > > <mailto:struts-dev-help@;jakarta.apache.org> > > > > > > > > > > > >-- > >To unsubscribe, e-mail: > ><mailto:struts-dev-unsubscribe@;jakarta.apache.org> > >For additional commands, e-mail: > ><mailto:struts-dev-help@;jakarta.apache.org> > > > _________________________________________________________________ > Add photos to your messages with MSN 8. Get 2 months FREE*. > http://join.msn.com/?page=features/featuredemail > > > -- > To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org> -- To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>
