David
From: "Karr, David" <[EMAIL PROTECTED]> Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Subject: RE: committers attention - just a few moments... Date: Tue, 25 Feb 2003 15:06:52 -0800
Failing responses from people who are actually familiar with the nested tags and your changes, then I think you'll just have to use your own judgment. I had to make a similar decision recently wrt the Struts-EL tags. Test your changes as much as possible, and try to get some feedback from people who are using your tags. If you think it's safe to commit, then do it (but don't quote me on that :) ).
> -----Original Message----- > From: Arron Bates [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 25, 2003 3:03 PM > To: [EMAIL PROTECTED] > Subject: committers attention - just a few moments... > > Peoples, > > I'm waiting on a call in the post below about the nested tags. I know > they're > not everyone's favorite component, but I do need committer attention to > form > the game plan as it's not the typical "bug fix". > > It's hard to form a consensus opinion on the one response I have. > > Copied below for convenience. > > > Arron. > > > > Original > Post_______________________________________________________________ > ------------------------------------------------------------------------ -- > -- > > Defenders of the faith, > > Just a small one to say the problem of of not being able to run the nested > tag > apps in Tomcat 4.1.18's funky Jasper engine has been tackled. > > I'd commit it, but the codebase being under release conditions, and for > the > fact that it's no simple few line "bug fix". The internals have changed to > leverage the request object more completely (was originally just used to > enable the recursive JSP markup). The NestedPropertyHelper has been gutted > and > mostly re-implemented, and all the nested tags have been touched to > accomodate the change. Instead of walking the tag hierarchy, all the child > tags now pick up on the nested reference within the request object > directly. > The property handling is now more pessimistic, and resets everything it > touches. All effort was made to respect all the minor changes the tags > have > undergone in fixing past bugs. > > The fact that most of it has changed means that I don't want it in this > release, but the fact that it allows people to deploy in the latest tomcat > release is important, something blocking an upgrade path for a lot of > people. > > What about, once the release is out, then the update to the tags > committed, > and release a bug-fix release for the new nested tags (1.1.1)?... kind of > like > 1.0.2 was to 1.0.1?... > > Too unstable for 1.1 so close to release, but too important to let it slip > for > over a year for it to come out. > > Needless to say it works on my apps :), but I'm asking the nested tags > user > base to jump onto it and give it a test run to see if it works for them. > For > those nesters looking on, there's a jar at... > > http://www.keyboardmonkey.com/downloads/km-nested-v2.jar > > ...just throw it into the WEB-INF/lib directory, your classloader should > pick them up before struts.jar. If not, delete the tags from struts.jar > and > give it another bash. > > Anyways, just thought I'd put it forward. > > Arron. > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
_________________________________________________________________
STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=features/junkmail
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
