Arron, My vote would be to move ahead with the changes. I have not reviewed the changes, but it looked like there might be some missmatched resets that would cause problems in the latest RC. I used the nested tags extensively on several sites and would rather deal with minor bugs/patches than sporadic problems.
Somehow I missed your message about a nested patch and just downloaded it this evening. I tested your new jar against several sites and came up with one problem. I have not spent the time to debug this properly, and I am using a nightly build from a couple of weeks ago, but it appears that there may be a problem. I have a fairly simple debugging page nested tags to display values from the JVM. I will download and build the latest nightly and retest. If the problem is still there I will post another message and send you that very simple page that appears to be failing. I will also try to test against a couple of other installations that use nested tags. David Morris >>> [EMAIL PROTECTED] 02/25/03 16:42 PM >>> > > Failing responses from people who are actually familiar with the nested > > tags and your changes, then I think you'll just have to use your own > > judgment. I had to make a similar decision recently wrt the Struts-EL > > tags. Test your changes as much as possible, and try to get some > > feedback from people who are using your tags. If you think it's safe to > > commit, then do it (but don't quote me on that :) ). > > > > David > > I think David articulates a rational approach. If you think the fix for > nested tags should go in (in spite of being a larger patch than we might > be normally comfortable with), and you've tested it as much as you can, > I'm certainly not going to argue. Worst case - we do an RC2 with this fix > to give the world one more shot at proving it's still got a problem. > > Craig > This is the feedback I'm after. Had I simply committed the patch that is on the big side, I would have been trounced. Especially seeing that time hasn't let me play apache recently, to then walk in and make such a large play (on RC1 day no less). Wouldn't have gone over well I imagine. Arron. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
