Hi,

I think there is a performance issue with
org.apache.struts.taglib.TagUtils.encodeURL(String).

Attached to this mail, four java classes that demonstrate and solve the
problem. You may run EncoderTest to compare the timings of the original
struts code with a faster encoder.

On my computer encodeURL takes about 0.2ms. This does not look like a big
issue, but encodeURL is called by computeUrl for each parameter name and
each parameter value. The web site I'm working on displays products lists.
There an average 3 links per product and 20 products per page + 20 other
links. Each of this links takes four parameters.

Total encodeURL time per page amounts to : (3*20+20)*(4*2)*0.2 = 128ms !
At the same time, the struts action + the JSP page takes about 200ms.

The attached encoder is at least 50 times faster. By using this encoder on
my application, the troughput was greatly improved.

If you are interrested, I can submit a patch


Pierre Maury

Attachment: encoder.zip
Description: Zip compressed data

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to