[ https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841098#comment-16841098 ]
Hadoop QA commented on SUBMARINE-57: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 38s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} yetus {color} | {color:red} 0m 7s{color} | {color:red} Unprocessed flag(s): --jenkins --skip-dir --mvn-args {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-SUBMARINE-Build/116/artifact/out/Dockerfile | | JIRA Issue | SUBMARINE-57 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12968888/SUBMARINE-57.001.patch | | Console output | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/116/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Add more elaborate message if submarine command is not recognized > ----------------------------------------------------------------- > > Key: SUBMARINE-57 > URL: https://issues.apache.org/jira/browse/SUBMARINE-57 > Project: Hadoop Submarine > Issue Type: Improvement > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Major > Attachments: SUBMARINE-57.001.patch > > > In {{org.apache.hadoop.yarn.submarine.client.cli.Cli#main}}, we have this > error handling: > {code:java} > if (args[0].equals("job")) { > String subCmd = args[1]; > if (subCmd.equals(CliConstants.RUN)) { > new RunJobCli(clientContext).run(moduleArgs); > } else if (subCmd.equals(CliConstants.SHOW)) { > new ShowJobCli(clientContext).run(moduleArgs); > } else { > printHelp(); > throw new IllegalArgumentException("Unknown option for job"); > } > } else { > printHelp(); > throw new IllegalArgumentException("Bad parameters <TODO>"); > } > {code} > "Bad parameters <TODO>" need to be replaced with someting making more sense. -- This message was sent by Atlassian JIRA (v7.6.3#76005)