[
https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841317#comment-16841317
]
Szilard Nemeth commented on SUBMARINE-57:
-----------------------------------------
Thanks [~adam.antal] for this patch!
+1 (non-binding)
> Add more elaborate message if submarine command is not recognized
> -----------------------------------------------------------------
>
> Key: SUBMARINE-57
> URL: https://issues.apache.org/jira/browse/SUBMARINE-57
> Project: Hadoop Submarine
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Adam Antal
> Priority: Major
> Attachments: SUBMARINE-57.001.patch
>
>
> In {{org.apache.hadoop.yarn.submarine.client.cli.Cli#main}}, we have this
> error handling:
> {code:java}
> if (args[0].equals("job")) {
> String subCmd = args[1];
> if (subCmd.equals(CliConstants.RUN)) {
> new RunJobCli(clientContext).run(moduleArgs);
> } else if (subCmd.equals(CliConstants.SHOW)) {
> new ShowJobCli(clientContext).run(moduleArgs);
> } else {
> printHelp();
> throw new IllegalArgumentException("Unknown option for job");
> }
> } else {
> printHelp();
> throw new IllegalArgumentException("Bad parameters <TODO>");
> }
> {code}
> "Bad parameters <TODO>" need to be replaced with someting making more sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
