Dirk,

On Wed, Jun 25, 2014 at 1:10 PM, Dirk Hohndel <[email protected]> wrote:

>
> So if you sent something that should have gone in (or that I didn't add
> and didn't respond to, either), please resend.
>

I've sent a patch on Jun 23 which fixes search panel toggle for user manual
using keyboard shortcut.

There're also several oddities in user manual as reported in
http://trac.hohndel.org/ticket/564

Finally I've managed to setup cross-build environment and confirm that
index links are OK in current master.

The problem with disappearing icons within search panel seems to be related
to Qt icon theme management under Windows
(
http://stackoverflow.com/questions/12299626/qt-use-of-qt-standard-icons-from-within-qt-creator-on-win7
).

Maybe our Qt gurus (Thiago or Tomaz) could give an advice on this issue.

Sergey
From 553d15392c2cd0adf4816e9b5da9abb61b578207 Mon Sep 17 00:00:00 2001
From: Sergey Starosek <[email protected]>
Date: Mon, 23 Jun 2014 12:06:20 +0400
Subject: [PATCH] Fix keyboard shortcuts for user manual
To: [email protected]

Shortcuts should have window context since there's no focus in any
widget.

Signed-off-by: Sergey Starosek <[email protected]>
---
 qt-ui/usermanual.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qt-ui/usermanual.cpp b/qt-ui/usermanual.cpp
index 0f31678..a57717a 100644
--- a/qt-ui/usermanual.cpp
+++ b/qt-ui/usermanual.cpp
@@ -20,12 +20,12 @@ UserManual::UserManual(QWidget *parent) : QMainWindow(parent),
 
 	QAction *actionShowSearch = new QAction(this);
 	actionShowSearch->setShortcut(Qt::CTRL + Qt::Key_F);
-	actionShowSearch->setShortcutContext(Qt::WidgetShortcut);
+	actionShowSearch->setShortcutContext(Qt::WindowShortcut);
 	addAction(actionShowSearch);
 
 	QAction *actionHideSearch = new QAction(this);
 	actionHideSearch->setShortcut(Qt::Key_Escape);
-	actionHideSearch->setShortcutContext(Qt::WidgetShortcut);
+	actionHideSearch->setShortcutContext(Qt::WindowShortcut);
 	addAction(actionHideSearch);
 
 	setWindowTitle(tr("User Manual"));
-- 
1.8.5.5

_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to