On Wed, Jun 25, 2014 at 04:07:02PM +0400, Sergey Starosek wrote:
> From 553d15392c2cd0adf4816e9b5da9abb61b578207 Mon Sep 17 00:00:00 2001
> From: Sergey Starosek <[email protected]>
> Date: Mon, 23 Jun 2014 12:06:20 +0400
> Subject: [PATCH] Fix keyboard shortcuts for user manual
> To: [email protected]
> 
> Shortcuts should have window context since there's no focus in any
> widget.

I'm curious about this one - the reason I changed this in commit
49053e86aa61a was that otherwise I would get conflicts with different
shortcuts (i.e., things were marked as ambiguous). Are you fixing an
actual but here, something that doesn't work? Or just a matter of
principle?

/D

> 
> Signed-off-by: Sergey Starosek <[email protected]>
> ---
>  qt-ui/usermanual.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qt-ui/usermanual.cpp b/qt-ui/usermanual.cpp
> index 0f31678..a57717a 100644
> --- a/qt-ui/usermanual.cpp
> +++ b/qt-ui/usermanual.cpp
> @@ -20,12 +20,12 @@ UserManual::UserManual(QWidget *parent) : 
> QMainWindow(parent),
>  
>       QAction *actionShowSearch = new QAction(this);
>       actionShowSearch->setShortcut(Qt::CTRL + Qt::Key_F);
> -     actionShowSearch->setShortcutContext(Qt::WidgetShortcut);
> +     actionShowSearch->setShortcutContext(Qt::WindowShortcut);
>       addAction(actionShowSearch);
>  
>       QAction *actionHideSearch = new QAction(this);
>       actionHideSearch->setShortcut(Qt::Key_Escape);
> -     actionHideSearch->setShortcutContext(Qt::WidgetShortcut);
> +     actionHideSearch->setShortcutContext(Qt::WindowShortcut);
>       addAction(actionHideSearch);
>  
>       setWindowTitle(tr("User Manual"));
> -- 
> 1.8.5.5
> 

_______________________________________________
subsurface mailing list
[email protected]
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to