On 13 November, 2014 - Dirk Hohndel wrote: > On Thu, Nov 13, 2014 at 11:04:23PM +0100, Anton Lundin wrote: > > Based on those dives to 69 meters, with 25 min bottom time, the > > deco-schedules differers 6 minutes (7% of total time, 18/40, 50%, 100%). > > I wouldn't have expected such a big difference, honestly. >
It's a bit of a "extreme" example, but a realistic one that I actually encountered, so I would argue that its valid. One nice thing with having salinity as a spinbox is that you can click it up and down and see how it affects your deco schedule in Subsurface =) > > I think correctness is preferred. If the rest of you thinks another > > spinbox complicates the planner ui too much or that 17 loc is to complex > > infrastructure for this feature, fine, don't take the patch. > > Ummm... > > commit a06befc0075c19afbec31130b6d1e0f4447a2498 > Author: Anton Lundin <[email protected]> > Date: Wed Nov 12 23:33:40 2014 +0100 > > Support different salinity in planner > > > Already went in yesterday. > Yesterday?!? Its just coming up on midnight and i sent it this morning? =) Ah. I didn't actually check if You had applied the patch before writing that email. I just guessed that he would have hold the patch while there was a discussion. //Anton -- Anton Lundin +46702-161604 _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
