On 20 March 2015 at 22:40, Abhinav Agarwal <[email protected]> wrote:
> While exporting a divelog to xml/ssrf, if given filename contains a dot it 
> doesnt get saved as intended. for eg: if given filename is 'divelog.first' it 
> should get saved as 'divelog.first.ssrf' but it gets saved as 
> 'divelog.first'. This happens only on linux and not on windows. If you were 
> to do the same on windows it would get saved as 'divelog.first.xml'. This 
> patch solves the issue. It is syntactically better than the previous patch I 
> submitted.
>

hello,

for the message body, your patch still has:
Content-Transfer-Encoding: base64

it makes the actual contents unreadable until it's applied (i.e. "git
am" decodes it). you should look into a way to fix that e.g. use "git
format-patch" and "git send-email" with their proper options.

other than that the change seems OK.

lubomir
--
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to