On 21 March 2015 at 16:47, Robert C. Helling
<[email protected]> wrote:
> I am not quite sure this is the correct logic. I would think one should 
> append an extension only (and then always) if the file name does not contain 
> a dot as otherwise the user has already chosen another extension explicitly.
>

i guess so!
this will break if the user wants an explicit extension.

>> Am 20.03.2015 um 21:40 schrieb Abhinav Agarwal <[email protected]>:
>>
>> While exporting a divelog to xml/ssrf, if given filename contains a dot it 
>> doesnt get saved as intended. for eg: if given filename is 'divelog.first' 
>> it should get saved as 'divelog.first.ssrf' but it gets saved as 
>> 'divelog.first'. This happens only on linux and not on windows. If you were 
>> to do the same on windows it would get saved as 'divelog.first.xml'. This 
>> patch solves the issue. It is syntactically better than the previous patch I 
>> submitted.
>

could you revisit the patch?
the idea would be to append an extension only if no extension is
specified by the user.

lubomir
--
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to