On 16 February 2017 at 16:55, Dirk Hohndel <[email protected]> wrote: > On Thu, Feb 16, 2017 at 08:14:34AM +1100, Rick Walsh wrote: > > On 16 February 2017 at 07:34, Stefan Fuchs <[email protected]> wrote: > > > > > Hi All, > > > > > > I stumbled across one small thing: > > > > > > In diveplannermodel.cpp there is a very simple function > emitDataChanged() > > > but it is not used consequently. Already a few lines below the same > code > > > (which is in fact only one line) is again used instead of calling the > > > function. > > > > > > Is there are reason for this or can we clean this up? > > No reason - thanks for catching that. > I love seeing you look at things like this and taking the initiative. > > > emitDataChanged() is also called from desktop-widgets/diveplanner.cpp > and > > profile-widget/profilewidget2.cpp, so I don't think we can get rid of > it. > > He did the opposite - he used it more consistently :-) >
I thought Stefan's idea was to get rid of the function because it wasn't used. But on re-reading he email, I realize I missed the point. Yes, using the function is a good idea. > > > One of the great things about git is that you can test the consequence > of a > > change, so by all means try and see what breaks. If you work in a new > > branch you can test something, decide if it's a good idea. If it is you > > make a commit, if not you fix it or checkout master (or your previous > > branch) again and forget about.. > > Yep. Git is pretty neat. Using git to maintain Subsurface while running > Linux has a very de-ja-Linus kinda feel to it :-) > > /D >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
