On 28-04-17 18:56, Jan Mulder wrote:
The short remark of Jef changed basically everything. So I replaced my
adapted libdivecomputer branch completely (but still under the same
name, sorry to anybody who already pulled it). The concept of the change
is now very simple.  Libdivecomputer just puts the initial setpoint in
OSTC3 CCR mode in the first sample, and now Subsurface is now working
straight from the box.

So anybody who wants to take a look, the updated code is now at
https://github.com/janmulder/libdc/tree/ostc3-upd, and there is no
update in Subsurface required anymore.

As a "bonus", also the battery percentage data that is recently added by
HW to the logbook of the OSTC3, is now also visible in Subsurface.

And finally a question for Jef: how do I submit commits for libdivecomputer?

You just did :-) I can easily pull the commit from github.

I think there is still something missing. You are now always emitting the setpoint sample, even for non-CCR dives. I think that's wrong and there should be an extra check.

Jef
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to