On 23 July 2017 at 17:26, Joakim Bygdell <[email protected]> wrote:
> > > In which way does a white button on a white background look better?? > > There is no styling what so ever on that button meaning that it will be > white > even when the dark theme is in use. > > White on a light background is what the Material guidelines say should be used for an off switch. https://material.io/guidelines/components/selection-controls.html#selection-controls-switch The switch colouring is styled according to the Material accent colour, which we set in main.qml. I agree it looks pretty poor with the dark theme, but if we set the accent colour to have the same sat and val (but blue hue) as the Material default, then it looks much better. Please try the attached patch and see what you think.
From a97a1de7b6595c995db3334900a55b5c4525d0ff Mon Sep 17 00:00:00 2001 From: Rick Walsh <[email protected]> Date: Sun, 23 Jul 2017 16:45:01 +1000 Subject: [PATCH] QML UI: Use lighter accent colour for dark theme According to https://doc.qt.io/qt-5/qtquickcontrols2-material.html, the default dark theme has the accent colour #F48FB1. This has HSV of (339, 105, 244). If we use those sat and val values, but keep the hue as 230 (same as blue theme), control accents look better. Signed-off-by: Rick Walsh <[email protected]> --- mobile-widgets/qml/main.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mobile-widgets/qml/main.qml b/mobile-widgets/qml/main.qml index 6ff17bc4..a82dbffb 100644 --- a/mobile-widgets/qml/main.qml +++ b/mobile-widgets/qml/main.qml @@ -369,7 +369,7 @@ if you have network connectivity and want to sync your data to cloud storage."), property color pinkSecondaryTextColor: "#757575" // colors for the dark theme - property color darkDarkerPrimaryColor: "#303F9f" + property color darkDarkerPrimaryColor: "#909FF4" property color darkDarkerPrimaryTextColor: "#ECECEC" property color darkPrimaryColor: "#3F51B5" property color darkPrimaryTextColor: "#ECECEC" -- 2.13.3
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
