On 23 July 2017 at 16:12, Dirk Hohndel <[email protected]> wrote: > > On Jul 23, 2017, at 12:18 AM, Rick Walsh <[email protected]> wrote: > > > > On 23 July 2017 at 18:57, Rick Walsh <[email protected]> wrote: > >> >> >> On 23 July 2017 at 17:26, Joakim Bygdell <[email protected]> wrote: >> >>> >>> >>> In which way does a white button on a white background look better?? >>> >>> There is no styling what so ever on that button meaning that it will be >>> white >>> even when the dark theme is in use. >>> >>> White on a light background is what the Material guidelines say should >> be used for an off switch. >> https://material.io/guidelines/components/selection- >> controls.html#selection-controls-switch >> >> The switch colouring is styled according to the Material accent colour, >> which we set in main.qml. I agree it looks pretty poor with the dark >> theme, but if we set the accent colour to have the same sat and val (but >> blue hue) as the Material default, then it looks much better. Please try >> the attached patch and see what you think. >> > So you don't have to apply and test it yourself, here is what I mean. I > think the dark theme is better with the lighter accent colour. > > > I like the colored switches much better. > But I think they need to be more similar in size to the check boxes, or > maybe the check boxes need to be more similar in size to them? > Either way, they should be consistent. > > /D > > Look at my latest PR, the checkboxes are gone.
-- Jocke
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
