> On Oct 3, 2017, at 11:30 AM, Lubomir I. Ivanov <[email protected]> wrote: >> That makes more sense. >> We need to figure out why we overwrite the stack! Can you set a memory >> breakpoint to see where this happens? >> > > i'm pretty sure we overwrite it with the following, when 'col' is OOB: > defaultWidth[col] = width
Ah. Yes > > but it's very hard to predict if the OOD override will harmful or not. Which is why I am not seeing the crashes in my build, yet others are. >>> fixes: >>> 1) add another element to defaultWidth[] for 'country' and iterate col >>> up to the size of defaultWIdth[]. >> >> can you submit a patch? > > yes, that's the trivial fix. > please, confirm with option 2. > >> >>> 2) move defaultWidth as a method in DiveTripModel, for safety >> > > i was thinking about hardcoding the pixel values in DiveTripModel > inside some method with error checking instead of a int array in > divelistview.cpp. > the idea is that once a new column is added the author should also > modify the method in question to return this column's width and that > would happen in the same source file. I like that - and it should error out in a debug build, but return '0' or something valid in a release build /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
