On 3 October 2017 at 21:41, Dirk Hohndel <[email protected]> wrote: > >> On Oct 3, 2017, at 11:30 AM, Lubomir I. Ivanov <[email protected]> wrote: >>> >>>> 2) move defaultWidth as a method in DiveTripModel, for safety >>> >> >> i was thinking about hardcoding the pixel values in DiveTripModel >> inside some method with error checking instead of a int array in >> divelistview.cpp. >> the idea is that once a new column is added the author should also >> modify the method in question to return this column's width and that >> would happen in the same source file. > > I like that - and it should error out in a debug build, but return '0' or > something valid in a release build >
ok, i will send a PR in ~30 minutes. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
