> On Oct 16, 2017, at 2:06 AM, Berthold Stoeger <[email protected]> > wrote: > > Dear all, > > On Sonntag, 15. Oktober 2017 22:08:52 CEST Berthold Stoeger wrote: > >> By the way, there seems to be a strange bug(?): for the first failed >> download I get an information window. For each subsequent retry there is an >> additional window. E.g. for the 5th failed download it opens 5 information >> windows at once.
I had noticed this myself a while ago but then never followed up... there always seems more important stuff to do :-( > Answering to myself here: The issue seems to be the > connect(&thread, SIGNAL(finished()), ...); > call in on_downloadCancelRetryButton_clicked(), which apparently is > accumulative. Moving this call to the constructor solves the "problem". > That being said, I don't understand anything of that Qt SIGNAL/SLOT > business. Moreover, there is a second connect call, which perhaps should > also be called only once. That makes sense. Would you be able to create a commit with "Signed-off-by" line? Or even a GitHub pull request? Thanks /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
