> On Oct 18, 2017, at 6:45 PM, Berthold Stoeger <bstoe...@mail.tuwien.ac.at> > wrote: > > Unrelated point: Perhaps I'm missing something obvious, but I think the code > in qt-ble.cpp leaks resources. Is it worth noting such things, or is this > work-in-progress so don't bother?
Always worth reporting. Some times we allow small leaks to keep code sane, but in general we try to do good housekeeping. > Example: > In line 333 a BLEObject is generated, but it seems not to be destroyed if one > of the two subsequent error conditions (l. 347, 362) happen. > > On the other hand, in the standard case, it's not obvious where the > controller > is destroyed. > > Or in line 132, a QLowEnergyService is generated (Qt documentation: the > caller > takes ownership) and the pointer stuffed in a list, but it doesn't seem to be > destroyed anywhere. All good points that need investigating. /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
