I'm ok with that


On April 10, 2018 2:42:06 AM PDT, "Jérémie Guichard" <djebr...@gmail.com> wrote:
>Ok, I'll create the new section in CodingStyle. What about converting
>file (CodingStyle) to markdown format?
>2018-04-09 16:44 GMT+02:00 Dirk Hohndel <d...@hohndel.org>:
>> On Apr 9, 2018, at 3:26 AM, Miika Turkia <miika.tur...@gmail.com>
>>> To cope with this I've prepared a change introducing a new
>>> file that is meant to collect such information: https://github.co
>>> m/Subsurface-divelog/subsurface/pull/1196 Any feedback is welcome.
>>> it is the one convention I learned during a recent pull request I
>>> I started with documenting the use of membuffer for string
>> What is the distinction between the existing CodingStyle and the
>> CONVENTIONS.md? IMO, what you currently have there could have easily
>> included in the CodingStyle. Having all the essential information in
>> place sounds better for newcomers.
>> I think I'll have to agree with Miika on this one. Fewer places to
>> through make it easier for people to find what they are looking for.
>> One could of course argue that using membuffer and other such
>> technically aren't coding style, but I think with a slightly more
>> interpretation of that term... simply add a section called
>"Conventions" to
>> the CodingStyle document and I think we will all be happier :-)
>> Then if/when the currently discussed pull request would be approved
>>> would be nice to reflect these changes in the corresponding page on
>>> https://subsurface-divelog.org. The question is: Was this page
>>> edited in Subsurface-website repository or was it actually generated
>>> markdown? If so, is the script available somewhere?
>>> IIRC these are edited directly.
>> The website is run on a WordPress instance that is synced (in a
>> fragile manner) with a GitHub repo. So the sources for the page in
>> should be here:
>> https://github.com/Subsurface-divelog/Subsurface-website/
>> blob/master/_pages/contributing.en
>> The translations of the website are unfortunately not as well
>> as one might hope (this is all volunteer work and it's tedious
>> but you can see the translations in the GitHub repo as well.
>> /D

from my phone.
subsurface mailing list

Reply via email to