Linus, > On 14. Feb 2020, at 21:19, Linus Torvalds <[email protected]> > wrote: > > NOTE NOTE NOTE! I really hope Robert can test this. None of my dives > have dive mode change events. So my testing was pretty darn limited.
my only test case is a dive I created with the planner with a bailout ascent. But I can confirm that your PR loads this dive correctly. But once more, I have to admit, a quick read through did not really reveal to me how it works when handling multiple strings. But I thought that given there is no clash between dive mode names and strings that can appear as event names, simply make name=„OC“ and similar a feature. Please have a look at https://github.com/Subsurface-divelog/subsurface/pull/2622 <https://github.com/Subsurface-divelog/subsurface/pull/2622> which also fixes the problem. What do you think? Best Robert
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
