> On Mar 6, 2020, at 5:03 PM, Christof Arnosti <[email protected]> wrote: >> And here you are losing me again :-) >> Are you suggesting that we could walk through the list of devices and try to >> populate the dropdowns on the download page accordingly? That sounds like a >> great idea. > Yes, that's exactly what I tried to suggest. Thanks for putting it in > understandable words, it's getting late here.
It is indeed. >>> I didn't consciously check for devices not entered in the >>> device_filter.xml, but I entered "my" PID/VID pair quite late in the >>> development cycle. I also have seen and used the "ask permission" popup >>> which happens when a device not in device_filter.xml is used. I will test >>> this tomorrow by removing "my" entry from the device_filter.xml. >>> >> >> Excellent. Should I wait for further updates from you before merging the >> current code? > Hmm... I'd propose that I add the CdcAcm-driver for the Icon HD VID/PID (if > this works then all the PID/VIDs from libdivecomputer.org/drivers.html are be > supported! :-D) tomorrow, and that you then merge the code if everything else > is fine. > That sounds excellent to me. I can test this and then merge the PR. > Work on the UI could be done in a separate branch, and I'm happy to help on > the driver side. > That was my plan. I'll do the UI / integration work and we'll figure out what's needed on the driver side to make this work. So exciting! /D
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
