On Fri, Apr 25, 2008 at 11:50 PM, Martin Dengler
<[EMAIL PROTECTED]> wrote:
> + self.palette = SpeakerPalette(_('My Speakers'), model=model)
> + self.set_palette(self.palette)
'set_palette' is the setter for the 'palette' property, so the second
line shouldn't be needed.
> + model.connect('notify::level', self._speaker_status_changed_cb)
> + model.connect('notify::muted', self._speaker_status_changed_cb)
> + self.connect('expose-event', self._expose_event_cb)
Callbacks should start with two underscores in order to avoid name clashes.
The rest looks good to me.
Thanks,
Tomeu
_______________________________________________
Sugar mailing list
Sugar@lists.laptop.org
http://lists.laptop.org/listinfo/sugar
