On Mon, Apr 28, 2008 at 03:49:12PM +0200, Tomeu Vizoso wrote:
> On Fri, Apr 25, 2008 at 11:50 PM, Martin Dengler
> <[EMAIL PROTECTED]> wrote:
>
> > + self.palette = SpeakerPalette(_('My Speakers'), model=model)
> > + self.set_palette(self.palette)
>
> 'set_palette' is the setter for the 'palette' property, so the second
> line shouldn't be needed.
Thanks, I'll remove. That code was cut & pasted from battery.py, so
I'm guilty of cargo-culting here.
>
> > + model.connect('notify::level', self._speaker_status_changed_cb)
> > + model.connect('notify::muted', self._speaker_status_changed_cb)
> > + self.connect('expose-event', self._expose_event_cb)
>
> Callbacks should start with two underscores in order to avoid name
> clashes.
Thanks -- others have pointed this out as well in other code sections
and I guess I missed those.
> Tomeu
Martin
pgpVzj1mJl35E.pgp
Description: PGP signature
_______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
