On Wed, Sep 24, 2008 at 11:03:01AM -0400, Chris Ball wrote:
> Hi Erik,
>
> > Hello all, On tabbing we are currently auto-toggling the frame.
> > Are we sure that this is necessary? Could we include a
> > configuration option to change this?
>
> Sounds good, I'd agree with just removing it completely.
Me too.
> > The attached patch to sugar optionally disables frame appearance if
> > the file /home/olpc/no-frame-on-tabbing exists. This is just a
> > proof-of-concept hack to make it easier to quickly enable and
> > disable the functionality and observe the performance change.
>
> The patch isn't attached, and the patch I found in the Trac ticket isn't
> useful -- it has no lines of context and doesn't even specify which file
> is being patched, so it can't be applied; please resend using "diff -u",
> or ideally "git diff".
Whooops! Two errors. I put the wrong patch on the ticket and didn't
even attach the patch to the email.
Attached is the right file. I'm fixing the ticket... is there any way
to delete files from a trac ticket?
Erik
diff --git a/src/view/tabbinghandler.py b/src/view/tabbinghandler.py
index e3153b0..54f2d4e 100644
--- a/src/view/tabbinghandler.py
+++ b/src/view/tabbinghandler.py
@@ -15,6 +15,7 @@
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
import logging
+import os
import gtk
import gobject
@@ -59,7 +60,8 @@ class TabbingHandler(object):
else:
shell = view.Shell.get_instance()
- self._frame.show(self._frame.MODE_NON_INTERACTIVE)
+ if not os.path.exists('/home/olpc/no-frame-on-tabbing'):
+ self._frame.show(self._frame.MODE_NON_INTERACTIVE)
def __timeout_cb(self):
self._activate_current()
_______________________________________________
Sugar mailing list
[email protected]
http://lists.laptop.org/listinfo/sugar
