On Wed, Sep 24, 2008 at 06:08:47PM +0200, Tomeu Vizoso wrote:
> On Wed, Sep 24, 2008 at 5:25 PM, Eben Eliason <[EMAIL PROTECTED]> wrote:
> > On Wed, Sep 24, 2008 at 10:52 AM, Erik Garrison <[EMAIL PROTECTED]> wrote:
> >> Hello all,
> >>
> >> On tabbing we are currently auto-toggling the frame.  Are we sure that
> >> this is necessary?  Could we include a configuration option to change
> >> this?
> >
> > I disagree that showing the Frame is a bad idea.  It emphasizes the
> > purpose of the top edge of the Frame, and provides context while
> > tabbing so that it's easy to see where you want to "get to".
> >
> >> Drawing the frame animation during tabbing robs us of processor right
> >> when we need it, slowing the perceived transition time between windows.
> >
> > Drawing the Frame does take a little effort, it's true.  Compositing
> > support should later speed this up a good deal.
> 
> We also shouldn't be autosaving when the activity is not dirty (most
> of the time when alt-tabbing).
> 
> May be easier to actually enable composition and disable autosaving
> (by editing activity.py) than speculating here about cutting
> functionality.

My observations are partly coming from testing on composition and no
autosave...  You're right that others should give it a whirl.

> Who could give this a try?

I have patches to enable composition in Sugar's main.py.  We'll have to
push xcompmgr into the builds as well.

I also have a patch to disable autosaving (again with a flag in home,
/home/olpc/no-auto-save).

For what it's worth I'm attaching them here.  Perhaps we should start a
new thread to discuss these?

Erik
diff --git a/src/main.py b/src/main.py
index 355565b..749e530 100644
--- a/src/main.py
+++ b/src/main.py
@@ -15,6 +15,7 @@
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 
 import os
+import subprocess
 import gettext
 
 import pygtk
@@ -45,6 +46,9 @@ def _start_matchbox():
 
     gobject.spawn_async(cmd, flags=gobject.SPAWN_SEARCH_PATH)
 
+def _start_xcompmgr():
+    subprocess.Popen(['xcompmgr', '-d', ':0.0'])
+
 def _setup_translations():
     locale_path = os.path.join(config.prefix, 'share', 'locale')
     domain = 'sugar'
@@ -88,6 +92,7 @@ def main():
 
     logger.start('shell')
 
+    _start_xcompmgr()
     _start_matchbox()
     _setup_translations()
 
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index b55a09d..97abbc7 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -575,7 +575,8 @@ class Activity(Window, gtk.Container):
         if self._active != active:
             self._active = active
             if not self._active and self._jobject:
-                self.save()
+                if not os.path.exists('/home/olpc/no-auto-save'):
+                    self.save()
 
     active = gobject.property(
         type=bool, default=False, getter=get_active, setter=set_active)
_______________________________________________
Sugar mailing list
[email protected]
http://lists.laptop.org/listinfo/sugar

Reply via email to