Just to make it more concrete, this is what I had to do to eliminate the questionable patches from my s6-packaging.
https://github.com/bukzor/s6-packaging/commit/0f3465c074446b73fac05defb6118925b92a3c5a In essence I vendor and build a gnu-make tarball before starting the s6 build. I'd prefer not to have to do this, but it's not the worst either. On Wed, Jul 29, 2015 at 1:07 PM, Buck Evan <[email protected]> wrote: > Thanks for the reply > > On Tue, Jul 21, 2015 at 2:39 PM, Laurent Bercot < > [email protected]> wrote: > >> On 21/07/2015 18:36, Buck Evan wrote: >> >>> Apparently the 'private' keyword was added in 3.82, but many of the >>> platforms I care about have older versions of make. >>> >>> Would you accept a patch to factor it out? >>> >> >> Short answer: probably not. Don't waste time on it. (But if you have >> one already, send it anyway - I promise I'll look at it, without >> promising I'll merge it.) >> > > >> If you have a magical one-liner patch that will solve everything with >> rainbows and butterflies and that I don't have to spend more than two >> minutes on to be convinced it does the right thing, then please send it. >> > > No patch with rainbows here. I simply removed the 'private' keywords. > I'm sure it could breaks something subtly, but I don't see how. > It's likely that I don't understand that feature well enough. >
