Looks good, Anders!  Thank you (esp. for the tests).  I will apply it to the 
trunk today.

Would you mind if I renamed the "drop" supervisorctl command to "remove"?

- C

Anders Quist wrote:
> For your consideration:
> 
>     $ PYTHONPATH=. python2.4 ./supervisor/supervisorctl.py
>     bar                              STOPPED    Not started
>     foo                              STOPPED    Not started
>     zegroup:baz                      STOPPED    Not started
>     zegroup:gazonk                   STOPPED    Not started
>     supervisor> help add
>     add <name> [...]        Activates any updates in config for process/group
>     supervisor> help drop
>     drop <name> [...]       Removes process/group from active config
>     supervisor> help reread
>     reread                  Reload the daemon's configuration files
>     supervisor> drop zegroup foo
>     zegroup: dropped
>     foo: dropped
>     supervisor> status
>     bar                              STOPPED    Not started
>     supervisor> add foo
>     foo: added process
>     supervisor> status
>     bar                              STOPPED    Not started
>     foo                              STOPPED    Not started
> 
> <fiddling in config file>
> 
>     supervisor> reread
>     baz: available
>     gazonk: available
>     zegroup: disappeared
>     supervisor> status
>     bar                              STOPPED    Not started
>     foo                              STOPPED    Not started
>     supervisor> add baz
>     baz: added process
>     supervisor> add zegroup
>     zegroup: ERROR (no such group or already active)
>     supervisor> reload
>     Really restart the remote supervisord process y/N? y
>     Restarted supervisord
>     supervisor> status
>     bar                              STOPPED    Not started
>     baz                              STOPPED    Not started
>     foo                              STOPPED    Not started
>     gazonk                           STOPPED    Not started
> 
> Remains to be implemented:
> 
>     supervisor> help refresh
>     refresh                 Reload config and stop, drop, add and restart
>                             processes as necessary
>     supervisor> help avail
>     avail                   Display all configured processes
> 
> Also, an 'add all' might be useful, as might a pattern argument to
> avail.
> 
> Some notes:
> 
> - currently, all configuration is reread, including that of
>   supervisord itself. However, it does not act on any changes (e.g.
>   logfiles renamed). Many of these changes could be handled.
> 
> - Configuration is reread without regard to server state. This
>   _appears_ to be fine, but I simply don't know the codebase well
>   enough to be sure.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> 
> Any and all feedback is appreciated.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Supervisor-users mailing list
> [email protected]
> http://lists.supervisord.org/mailman/listinfo/supervisor-users

_______________________________________________
Supervisor-users mailing list
[email protected]
http://lists.supervisord.org/mailman/listinfo/supervisor-users

Reply via email to