Roger Hoover wrote: > Do you mind if I conditionalize the mock tests? Since they are only > unit tests and not required for runtime, it shouldn't hurt anything. > > There are already tests in the codebase that have this structure: > > if sys.version_info[:2] >= (2, 4): > #define test case here
I would prefer not to do this if we can avoid it. There is one conditional like that in the suite already but there's not a way around the existing one. It's a test for supervisord's --profile option (a development aid). In that case, supervisord is using features of the profile module from the stdlib that weren't available before 2.4. This is the only test that's conditional by Python version to my knowledge. I know that you have already done a lot of work on this patch and we appreciate it. If it will help, I will volunteer to make the changes. Thanks, Mike -- Mike Naberezny Maintainable Software http://maintainable.com _______________________________________________ Supervisor-users mailing list [email protected] http://lists.supervisord.org/mailman/listinfo/supervisor-users
