On Tuesday, 27 March 2007 12:09, Tim Dijkstra wrote:
> On Tue, 27 Mar 2007 11:55:03 +0200
> "Luca Tettamanti" <[EMAIL PROTECTED]> wrote:
> 
> > On 3/27/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote:
> > > This is a first cut at supporting powerpc for s2*. For the s2ram bit it
> > > basically removes the vbetool code. This has two reasons. First, there
> > > isn't a powerpc version of libx86 yet. Second, the machines that have
> > > support for s2ram in the kernel don't need those hacks.
> > 
> > Hum, scattering #ifdef all over the code quickly turns into a
> > maintenance nightmare.
> 
> Well, yeah, it's not pretty. We do need to rip out most of it. Any
> better ideas? Make noop functions for everything we do not have on
> powerpc?

Something like this, I think.  Move the functions that are not available on PPC
to a separate .c file and add a header file for them.

Greetings,
Rafael

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to