On 3/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote:
> Hehe, i replied on the wrong list :-)
>
> > With this patch people can at least compile and give us some feedback.
>
> ok, some comments inlined.
>
> > int s2ram_prepare(void)
> > {
> > +#ifdef CONFIG_PPC
> > + return 0;
> > +#else
> > int ret, id;
> >
> > dmi_scan();
>
> how about:
>
> #ifdef CONFIG_PPC
> #define s2ram_prepare() 0
> #else
> int s2ram_prepare(void)
> {
> ...
> }
> #endif
>
> This lets the compiler optimize this stuff out very well.
Better use this:
#define s2ram_prepare() do { } while (0)
otherwise gcc complains. Or just make it a real function, gcc is smart
enough ;-)
Luca
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
