Sorry for coming late to the party...

On Fri, Jul 20, 2007 at 08:56:15PM +0300, Alon Bar-Lev wrote:
> 
> Hello Rafael,
> 
> Yet another patch in the suspend2 feature-set series.
> It sets cpufreq to maximum during the cycle.
> It is important to finish the process as quickly as possible (human engineer 
> issue :) )
> When running on batteries it may take forever without this...
> 
> Please consider to apply.

Strong NAK.

This is lots of stuff in suspend that does not belong there. Nowadays, cpufreq
is usually handled via HAL's cpufreq-addon. So to do this correctly, you'd
need to send a message to HAL to tell him to switch to full speed. This,
again, is much easier done in pm-utils, or even inside HAL or HAL's cpufreq
addon itself.

You don't want to change this stuff behind HAL's back, that's just asking for
trouble.
And AFAIK, almost everybody just has "switch to full speed before calling
s2disk" in his wrapper scripts, if he really wants to.

-- 
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to