On 05/10/2007 04:49 PM Frederik Holljen wrote: > On Sunday 06 May 2007 00:02, Tobias Schlitt wrote: >> Author: Tobias Schlitt >> Date: 2007-05-05 22:02:55 +0200 (Sat, 05 May 2007) >> New Revision: 5069
>> Log: >> - Implemented feature #9089: Make some methods public. >> ezcPersistentSession->generateAliasMap() and ->getColumnsFromDefinition() >> are public now. > Toby: Why are we making these methods public? Why polluting the session class > with these public methods? Are you sure they should not be protected instead > or put into some utility class? Putting those in a utility class sounds fine to me. However, it was requested on the ML some time ago to make those methods public and since nobody objected so far, I simply did. @Derick: Any harm, if we do a move now? Else I would suggest making them private again and re-open the issue for 2007.2. Regards, Toby -- Mit freundlichen Grüßen / Med vennlig hilsen / With kind regards Tobias Schlitt (GPG Key: 0xC462BC14) System Developer for the eZ Components project ****************************************** eZ systems GmbH Emil-Figge-Str. 76-80 44227 Dortmund Germany/Deutschland Geschäftsführer: Ralf Rutke Handelregister: AG Dortmund, HRB 18800 E-Mail: [EMAIL PROTECTED] Web: www.ez.no Tel: +49 (0) 231-9742-7750 ****************************************** -- svn-components mailing list [email protected] http://lists.ez.no/mailman/listinfo/svn-components
