On Thursday 10 May 2007 18:55, Tobias Schlitt wrote: > On 05/10/2007 04:49 PM Frederik Holljen wrote: > > On Sunday 06 May 2007 00:02, Tobias Schlitt wrote: > >> Author: Tobias Schlitt > >> Date: 2007-05-05 22:02:55 +0200 (Sat, 05 May 2007) > >> New Revision: 5069 > >> > >> Log: > >> - Implemented feature #9089: Make some methods public. > >> ezcPersistentSession->generateAliasMap() and > >> ->getColumnsFromDefinition() are public now. > > > > Toby: Why are we making these methods public? Why polluting the session > > class with these public methods? Are you sure they should not be > > protected instead or put into some utility class? > > Putting those in a utility class sounds fine to me. However, it was > requested on the ML some time ago to make those methods public and since > nobody objected so far, I simply did. > > @Derick: Any harm, if we do a move now?
I don't mind having them there if they are protected. Are they useful anywhere else than descendants of PersistentSession? Frederik -- svn-components mailing list [email protected] http://lists.ez.no/mailman/listinfo/svn-components
