On 14/10/2015 13:12, Alexander Motin wrote: > Author: mav > Date: Wed Oct 14 11:12:47 2015 > New Revision: 289310 > URL: https://svnweb.freebsd.org/changeset/base/289310 > > Log: > 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R
Thank you very much for importing this complex commit. I have one question below. > Reviewed by: George Wilson <[email protected]> > Reviewed by: Prakash Surya <[email protected]> > Reviewed by: Saso Kiselkov <[email protected]> > Reviewed by: Richard Lowe <[email protected]> > Approved by: Garrett D'Amore <[email protected]> > Author: Matthew Ahrens <[email protected]> > > illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f > > Added: > vendor-sys/illumos/dist/uts/common/crypto/ > vendor-sys/illumos/dist/uts/common/crypto/io/ > vendor-sys/illumos/dist/uts/common/crypto/io/edonr_mod.c (contents, props > changed) > vendor-sys/illumos/dist/uts/common/crypto/io/skein_mod.c (contents, props > changed) Do we actually need these two file in the vendor area? They look like illumos crypto drivers to me, so I think that it is unlikely that we will have a use for them. Or do you have some big plans about that? :-) > vendor-sys/illumos/dist/uts/common/fs/zfs/edonr_zfs.c (contents, props > changed) > vendor-sys/illumos/dist/uts/common/fs/zfs/skein_zfs.c (contents, props > changed) > vendor-sys/illumos/dist/uts/common/sys/edonr.h (contents, props changed) > vendor-sys/illumos/dist/uts/common/sys/skein.h (contents, props changed) -- Andriy Gapon _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
