On 14/10/2015 13:12, Alexander Motin wrote:
> Author: mav
> Date: Wed Oct 14 11:12:47 2015
> New Revision: 289310
> URL: https://svnweb.freebsd.org/changeset/base/289310
> 
> Log:
>   4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R
>   
>   Reviewed by: George Wilson <[email protected]>
>   Reviewed by: Prakash Surya <[email protected]>
>   Reviewed by: Saso Kiselkov <[email protected]>
>   Reviewed by: Richard Lowe <[email protected]>
>   Approved by: Garrett D'Amore <[email protected]>
>   Author: Matthew Ahrens <[email protected]>
>   
>   illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f
> 
> Added:
>   vendor/illumos/dist/common/crypto/
>   vendor/illumos/dist/common/crypto/edonr/
>   vendor/illumos/dist/common/crypto/edonr/edonr.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h   (contents, 
> props changed)
>   vendor/illumos/dist/common/crypto/skein/
>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE   (contents, 
> props changed)
>   vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip   
> (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein.c   (contents, props changed)
>   vendor/illumos/dist/common/crypto/skein/skein_block.c   (contents, props 
> changed)
>   vendor/illumos/dist/common/crypto/skein/skein_impl.h   (contents, props 
> changed)
>   vendor/illumos/dist/common/crypto/skein/skein_iv.c   (contents, props 
> changed)
>   vendor/illumos/dist/common/crypto/skein/skein_port.h   (contents, props 
> changed)

It seems that these are pieces of code that can be used by both the
userland and the kernel.  I think that previously we used to import such
code into illumos-sys and then integrate it into sys/cddl (e.g.
common/zfs/).  Perhaps it is worthwhile following that convention in
this case as well?

> Modified:
>   vendor/illumos/dist/lib/libzfs/common/libzfs_dataset.c
>   vendor/illumos/dist/man/man5/zpool-features.5

Also, we probably need to synchronize man/man1m/zfs.1m in our vendor
area with the latest upstream version.  Even though we do not directly
use that file, it still would be easier to make the future imports and
also to compare (and to keep in sync) our version of the manual with the
upstream version.

Thank you for doing all the heavy lifting with this change!

-- 
Andriy Gapon
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to