On Fri, Jan 08, 2016 at 01:22:45PM -0800, NGie Cooper wrote: N> > 1) The review requests were sent continuosly to arch@ during last 1.5 years. N> > N> > https://lists.freebsd.org/pipermail/freebsd-arch/2014-May/015385.html N> > N> > 2) Team of engineers at Netflix has a lot of code build on top of that code, N> > e.g. SSL_sendfile(). Of course, writing something on top assumes reviewing, N> > so assume it reviewed thoroughly by rrs@. Actually, here is list of people N> > who did some review of the code: emax@, rrs@, scottl@, gallatin@, imp@. N> > N> > 3) Do you have any particulars concerns with this change or those made recently N> > to sys/kern and sys/net*? N> N> I don’t as of right now, other than it’s really difficult to audit changes and assess risk if someone doesn’t have access to the CRs :(. N> N> Also… N> N> N> > An N> N> > explanation of why such behavior is beneficial compared to old one is N> N> > going to be too long for a commit message, so we will skip it here. N> N> This wasn’t really helpful. It would have been nice if there was a wiki page or some other reference used in this commit which would have described the where, why, and how behind this change a lot more.
I'm writing status report on this right now. Also there is slideshare: http://www.slideshare.net/facepalmtarbz2/new-sendfile-in-english And there is even a paper, alas in Russian. -- Totus tuus, Glebius. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"