Antoine, On Sat, Jan 09, 2016 at 07:41:57PM +0000, Antoine Brodin wrote: A> On Fri, Jan 8, 2016 at 8:34 PM, Gleb Smirnoff <gleb...@freebsd.org> wrote: A> > Author: glebius A> > Date: Fri Jan 8 20:34:57 2016 A> > New Revision: 293439 A> > URL: https://svnweb.freebsd.org/changeset/base/293439 A> > A> > Log: A> > New sendfile(2) syscall. A joint effort of NGINX and Netflix from 2013 and A> > up to now. A> A> Hi, A> A> "SF_FLAGS" addition seems to break graphics/graphviz on head. A> See error log at: A> http://beefy3.nyi.freebsd.org/data/head-i386-default/p405601_s293454/logs/errors/graphviz-2.38.0_10.log A> 739 ports are skipped due to this failure.
I'm reluctant to fix that on our side. The problem comes from lib/sfio/sfhdr.h in graphviz. This file first includes "sfio_t.h", a local definitions file, and then includes system includes. This is clearly an mistake, and the breakage is exactly the consequence of such kind of mistakes. I can't imagine a situation when you do want system wide definitions to overtake yours. So I suggest to put a patch in the port and submit it upstream. Any objections? I can do it myself, but would be grateful if maintainer provides help. -- Totus tuus, Glebius. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
