I tried to rationalize... "in what case is it actually _desirably_ that the
left or right command key _should_ generate an escape sequence
and thus cancel the existing dialog" and I couldn't think of any.
That being said... I'm still happy to move it. Can you have a look at the
attached patch to see if matches what you envision?
--
Devin
On Dec 21, 2013, at 6:49 AM, Nathan Whitehorn wrote:
> Could you please revert this and move the fix to the correct place?
> -Nathan
>
> On 12/16/13 10:06, Nathan Whitehorn wrote:
>> Please add this to release/rc.local instead under the console setup.
>> There is no guarantee that "auto" is running from an environment where
>> this is defined -- for example, it may be running from a serial
>> console or an xterm -- and the actual installer should not be polluted
>> with assumptions about the media from which it runs.
>> -Nathan
>>
>> On 12/16/13 09:50, Devin Teske wrote:
>>> Author: dteske
>>> Date: Mon Dec 16 15:50:59 2013
>>> New Revision: 259468
>>> URL:
>>> https://urldefense.proofpoint.com/v1/url?u=http://svnweb.freebsd.org/changeset/base/259468&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=aed75882069cc72d4a372f6471f113be19fcb6eeeca132b424719ac3b459e2a3
>>>
>>> Log:
>>> Add a fix for Long-standing problem with VMware. Described in
>>> below links:
>>>
>>> https://urldefense.proofpoint.com/v1/url?u=https://communities.vmware.com/thread/107230&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=eb4a25314cb93209718bd46c3a142e1a92fac348d3cdf720b26f416b6061cd17
>>>
>>> https://urldefense.proofpoint.com/v1/url?u=https://communities.vmware.com/docs/DOC-11677&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=VPzUmM2go2WySxuU4i4nAG5Ox61QodkXwD4Z7CaXvls%3D%0A&s=2837df54aadfa9de8e081ac53a233ed2dc52f2f4a2be08ae75fefcdd4ee1ddbd
>>> Basically, ignore the ``function 62'' and ``function 63''
>>> interpretations
>>> of the left/right command key when we're in the lengthiest portion
>>> of the
>>> installation (initiated by the `auto' module).
>>> The net effect is that you can now (once you've started the
>>> installer from
>>> the media) escape the VM without prematurely terminating the
>>> current action
>>> due to spurious escape sequence.
>>> MFC after: 3 days
>>>
>>> Modified:
>>> head/usr.sbin/bsdinstall/scripts/auto
>>>
>>> Modified: head/usr.sbin/bsdinstall/scripts/auto
>>> ==============================================================================
>>>
>>> --- head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:08:30
>>> 2013 (r259467)
>>> +++ head/usr.sbin/bsdinstall/scripts/auto Mon Dec 16 15:50:59
>>> 2013 (r259468)
>>> @@ -49,6 +49,10 @@ error() {
>>> ############################################################ MAIN
>>> +# Don't send ESC on function-key 62/63 (left/right command key)
>>> +f_quietly kbdcontrol -f 62 ''
>>> +f_quietly kbdcontrol -f 63 ''
>>> +
>>> f_dprintf "Began Installation at %s" "$( date )"
>>> rm -rf $BSDINSTALL_TMPETC
>>
>
_____________
The information contained in this message is proprietary and/or confidential.
If you are not the intended recipient, please: (i) delete the message and all
copies; (ii) do not disclose, distribute or use the message in any manner; and
(iii) notify the sender immediately. In addition, please be aware that any
message addressed to our domain is subject to archiving and review by persons
other than the intended recipient. Thank you.
Index: release/rc.local
===================================================================
--- release/rc.local (revision 259684)
+++ release/rc.local (working copy)
@@ -19,6 +19,10 @@ if [ $? -eq 0 ]; then
TERM=xterm
fi
+ # Don't send ESC on function-key 62/63 (left/right command key)
+ f_quietly kbdcontrol -f 62 ''
+ f_quietly kbdcontrol -f 63 ''
+
if [ -z "$EXTERNAL_VTY_STARTED" ]; then
# Init will clean these processes up if/when the system
# goes multiuser
Index: usr.sbin/bsdinstall/scripts/auto
===================================================================
--- usr.sbin/bsdinstall/scripts/auto (revision 259618)
+++ usr.sbin/bsdinstall/scripts/auto (working copy)
@@ -49,10 +49,6 @@ error() {
############################################################ MAIN
-# Don't send ESC on function-key 62/63 (left/right command key)
-f_quietly kbdcontrol -f 62 ''
-f_quietly kbdcontrol -f 63 ''
-
f_dprintf "Began Installation at %s" "$( date )"
rm -rf $BSDINSTALL_TMPETC
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
