On 12/21/13 10:25, Teske, Devin wrote: > On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: > >> Looks great, thanks -- although you don't need the f_quietly, which >> isn't defined there. >> >> The issue is that this patch very specific to running the installer on a >> video console. There are many circumstances in which it is not, in which >> case this will fail (e.g. a serial console). The other thing is that the >> installer should not reconfigure the host system unless it has been >> explicitly asked to. It isn't always run from the install media. If you >> think the default bindings for these keys don't make sense, then that >> should ultimately be fixed in the console driver as well. > My inspiration for this change came from a tweet in which we were > (unjustly or not; doesn't matter) slammed for not having addressed > this issue since it (as the person claims) first appeared in 6.x. > > Having felt the persons pain (and verified that, indeed, we continue > to be plagued in 10) I decided to do start researching the problem > in-depth. > > The links I posted in the commit message give an excellent view of > the issue and in-fact doesn't even mention using kbdcontrol. Instead > it is suggested that we create an alternate keymap that ignores the > command keys. > > That sounds like one approach (and wins points because it is opt- > in) but it doesn't solve the problem for me or anyone else running > the installer. > > Perhaps if we had this alternate keymap in the base which does the > desired thing (ignore the command keys), then we could just say that > the user ought to select said keymap at the onset of the installation > process. > > But I'm not sure *I* like that approach because then it means that for > my own testing, I have to select an alternate keymap everytime I run > the installer in VMware. > > Rather, it seems to me that the installation process, if it ignored the > command key on every non-serial platform... this would be fine. > Afterall, once they get the system installed, they'll have the desired > keymap set and they can forget.
I'd prefer opt-out -- having the default be the option that is least surprising is a good idea. In any case, moving it to rc.local solves all the immediate problem. -Nathan _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
